Added block.MetaFetcher logic for resilient sync of meta files. #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
force-pushed
the
meta-syncer
branch
2 times, most recently
from
28e5519
to
c12fda9
Compare
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
changed the title
This is meant to replace many inconsistent meta.json syncs places in other components. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
This was referenced Jan 3, 2020
GiedriusS
reviewed
Jan 4, 2020
pkg/block/fetcher.go
Outdated
|
|
||
| m := &metadata.Meta{} | ||
| if err := json.Unmarshal(metaContent, m); err != nil { | ||
| return nil, errors.Wrapf(ErrorSyncMetaCorrupted, "meta.json %v unmarshal: %v ", metaFile, err) |
There was a problem hiding this comment.
Small nit: that space at the end seems unnecessary. The same happened on some other lines as well.
GiedriusS
reviewed
Jan 4, 2020
| // Filter's label values. | ||
| labelExcludedMeta = "label-excluded" | ||
| timeExcludedMeta = "time-excluded" | ||
| TooFreshMeta = "too-fresh" |
There was a problem hiding this comment.
Nit: does this need to be exposed?
GiedriusS
approved these changes
Jan 4, 2020
GiedriusS
reviewed
Jan 4, 2020
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to replace least 5 inconsistent meta.json syncs places across components.
Usage of those will be done in follow up chained PRs.
In the first commit: Transactional gauge allowing to have atomic gauge across different labels.
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com