Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped minio-go library to v6.0.45 #2033

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Bumped minio-go library to v6.0.45 #2033

merged 2 commits into from
Jan 24, 2020

Conversation

robcoward
Copy link
Contributor

@robcoward robcoward commented Jan 23, 2020

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Bump to the minio-go library to support Web Identity providers for IAM credentials for AWS EKS - Fixes #1494

Verification

Have built a new docker image with the updated library and confirmed that when deployed on EKS with a service account, it correctly uses the service account's IAM role to grant access to S3.

Signed-off-by: Rob Coward <rob.coward@devops-consultants.co.uk>
Signed-off-by: Rob Coward <rob.coward@devops-consultants.co.uk>
@robcoward
Copy link
Contributor Author

Seems like CircleCI may have had some intermittent connectivity failure:

level=error msg="function failed. Retrying in next tick" err="perform GET request against http://localhost:10015/api/v1/query?dedup=false&partial_response=true&query=sum%28up%29+without+%28instance%29&time=2020-01-23T13%3A45%3A47.150077456Z: Get http://localhost:10015/api/v1/query?dedup=false&partial_response=true&query=sum%28up%29+without+%28instance%29&time=2020-01-23T13%3A45%3A47.150077456Z: dial tcp 127.0.0.1:10015: connect: connection refused"

I don't have access to trigger a rebuild - can anyone else, or shall I make a new commit to trigger the whole process off again ?

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

LGTM 👍

@bwplotka
Copy link
Member

I restarted the CI, it's flaky due to VM slowdowns sometimes. We are on a way to move to GH actions (:

@bwplotka bwplotka merged commit 860460c into thanos-io:master Jan 24, 2020
@omerlh
Copy link
Contributor

omerlh commented Jan 24, 2020

Thank you! When this fix supposed to be released?

1 similar comment
@omerlh
Copy link
Contributor

omerlh commented Jan 24, 2020

Thank you! When this fix supposed to be released?

@bwplotka
Copy link
Member

bwplotka commented Jan 25, 2020

In ~5 weeks, so I would suggest grabbing master image (:

@omerlh
Copy link
Contributor

omerlh commented Jan 26, 2020

Ohhh I see... Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Web Identity providers for IAM credentials for AWS EKS
3 participants