Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Add servername to grpc dial options for DNS stores (Fixes #1507) #2407

Closed
wants to merge 5 commits into from
Closed

Query: Add servername to grpc dial options for DNS stores (Fixes #1507) #2407

wants to merge 5 commits into from

Commits on Apr 10, 2020

  1. Add servername to grpc dial options for DNS stores (thanos-io#1507) 

    To avoid needing a query per remote cluster, get the name to add to
the dial options from the dns provider when making the grpc connection.

Signed-off-by: JP Sullivan <jonpsull@cisco.com>
    @j3p0uk
    j3p0uk committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    57757c1 View commit details
    Browse the repository at this point in the history

  2. Conditionally add TLS when connecting to a store 

    The grpc-client-dns-server-name needs to propogate to the storeset so that
TLS is conditionally added to the grpc dialOpts based on whether it is set.

Test that the grpc-client-tls-secure flag is also set when the
grpc-client-dns-server-name flag is set to make it clear that a secure store
connection is required when using the latter flag.

Signed-off-by: JP Sullivan <jonpsull@cisco.com>
    @j3p0uk
    j3p0uk committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    e80c342 View commit details
    Browse the repository at this point in the history

  3. Update docs 

    Signed-off-by: JP Sullivan <jonpsull@cisco.com>
    @j3p0uk
    j3p0uk committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    128242f View commit details
    Browse the repository at this point in the history

  4. Add full stops to complete comment sentences 

    Signed-off-by: JP Sullivan <jonpsull@cisco.com>
    @j3p0uk
    j3p0uk committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    c203179 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2020

  1. Review comment updates 

    * Comment formatting
* Changelog formatting
* Remove nginx references

Signed-off-by: JP Sullivan <jonpsull@cisco.com>
    @j3p0uk
    j3p0uk committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    909189c View commit details
    Browse the repository at this point in the history