Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compact: unwrap the original error as well #2637

Merged
merged 3 commits into from
May 21, 2020
Merged

compact: unwrap the original error as well #2637

merged 3 commits into from
May 21, 2020

Commits on May 21, 2020

  1. compact: unwrap the original error as well 

    Just like in IsHaltError(), let's unwrap the given error to see if is
`terrors.MultiError`. This lets us detect the retryable errors as well:

* `BucketCompactor.Compact` returns `terrors.MultiError` of wrapped
errors;
* `compactMainFn` wraps the previously returned error again.

So, we need to unwrap it at the beginning, iterate over it, and then
unwrap again which is what the code does with this change.

Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
    @GiedriusS
    GiedriusS committed May 21, 2020
    Configuration menu
    Copy the full SHA
    a50a227 View commit details
    Browse the repository at this point in the history

  2. compact: test: add case for wrapped retryable error 

    Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
    @GiedriusS
    GiedriusS committed May 21, 2020
    Configuration menu
    Copy the full SHA
    0e94361 View commit details
    Browse the repository at this point in the history

  3. CHANGELOG: update 

    Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
    @GiedriusS
    GiedriusS committed May 21, 2020
    Configuration menu
    Copy the full SHA
    2ef52fa View commit details
    Browse the repository at this point in the history