Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed legacy index.cache.json support #2667

Merged
merged 2 commits into from
May 28, 2020

Conversation

pracucci
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

After a brief discussion on Slack, in this PR I'm proposing to completely remove the legacy index.cache.json support, considering the binary index header is no longer experimental since v0.12.

A part from some code cleanup, the primary benefit is no longer generating the index.cache.json during compaction.

Verification

Existing tests.

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Awesome, LGTM.

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci force-pushed the remove-index-cache-json-support branch from 4981d5c to 398983b Compare May 28, 2020 07:25
@bwplotka bwplotka merged commit 63ef382 into thanos-io:master May 28, 2020
@bwplotka
Copy link
Member

Thanks!

@pracucci pracucci deleted the remove-index-cache-json-support branch May 28, 2020 09:22
thisisobate pushed a commit to thisisobate/thanos that referenced this pull request Jun 1, 2020
* Removed legacy index.cache.json support

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Added CHANGELOG entry

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants