Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(release branch) query: irate and resets use now counter downsampling aggregations. #2719

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Jun 4, 2020

See related discussion: https://cloud-native.slack.com/archives/CL25937SP/p1590408991325100

cc @SuperQ

Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com

@bwplotka
Copy link
Member Author

bwplotka commented Jun 4, 2020

Lack of deep testing, but given it's simple change I would be confident to give it a try without sample based test.

@bwplotka bwplotka changed the title Store: irate and resets use now counter downsampling aggregations. (release branch) store: irate and resets use now counter downsampling aggregations. Jun 4, 2020
@bwplotka bwplotka force-pushed the add-missing-counter-functions branch from 0e3beff to af02b4d Compare June 4, 2020 17:11
@bwplotka bwplotka mentioned this pull request Jun 4, 2020
@bwplotka bwplotka changed the title (release branch) store: irate and resets use now counter downsampling aggregations. (release branch) query: irate and resets use now counter downsampling aggregations. Jun 4, 2020
@bwplotka bwplotka merged commit 2f9e4e9 into release-0.13 Jun 4, 2020
@bwplotka bwplotka deleted the add-missing-counter-functions branch June 4, 2020 17:19
paulfantom added a commit to paulfantom/thanos that referenced this pull request Jul 8, 2020
openshift/master

* upstream/release-0.13:
  Cut release v0.13.0
  shipper: Be strict about upload order unless it's specified so & cut v0.13.0-rc.2 (thanos-io#2765)
  Cut 0.13.0 release. (thanos-io#2762)
  Cut release 0.13.0-rc.1 (thanos-io#2720)
  Store: `irate` and `resets` use now counter downsampling aggregations. (thanos-io#2719)
  deps: Updated minio-go dependency to v6.0.56 to add two region endpoints (thanos-io#2705) (thanos-io#2718)
  store/proxy: Deduplicate chunks on StoreAPI level. Recommend chunk sorting for StoreAPI + Optimized iter chunk dedup. (thanos-io#2710) (thanos-io#2711)
  Allow using multiple memcached clients at the same time. (thanos-io#2648) (thanos-io#2698)
  Updated Prometheus as little as possible to include Isolation fix. (thanos-io#2697)
  Release fix attempt2.
  Fixed test job. (thanos-io#2650)
  Fixed promu build to build in compatible directory that crossbuild understands.
  Cut v0.13.0-rc.0 (thanos-io#2628)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants