Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed navbar toggle icon to be visible #2795

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

thisisobate
Copy link
Contributor

@thisisobate thisisobate commented Jun 23, 2020

Signed-off-by: thisisobate obasiuche62@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

I fixed visibility of Navbar hamburger menu icon by updating bootstrap,popperJS, and Jquery CDN to latest. Due to CSP issues, I used fontawesome icon instead in replace of bootstrap. With this, I was able to overcome CSP issues.

Verification

Works on local

Signed-off-by: thisisobate <obasiuche62@gmail.com>
@thisisobate
Copy link
Contributor Author

@bwplotka @squat Awaiting your reviews ;)

@bwplotka
Copy link
Member

Thanks! Works perfectly now 👍

@bwplotka bwplotka merged commit 1bdc2e6 into thanos-io:master Jun 23, 2020
@thisisobate thisisobate deleted the hamburger-fix branch June 24, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants