Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive: Fixing auto-configuration of --receive.local-endpoint #2937

Merged
merged 2 commits into from
Jul 27, 2020

Conversation

jrepp
Copy link
Contributor

@jrepp jrepp commented Jul 24, 2020

  • I added CHANGELOG entry for this change.

Changes

Updated code that configures the local endpoint if --receive.local-endpoint is not specified.

Verification

Tested on a 3 node cluster in GKE using a StatefulSet deployment. In this case the node upon startup will use local hostname which includes the StatefulSet pod index, e.g: thanos-receive-us-west2-1. The GRPC port is appended and this lines up with the hash ring configuration. All nodes in hash-ring then begin to correctly participate in replication of time series.

Signed-off-by: Jacob Repp <jacobrepp@gmail.com>
Signed-off-by: Jacob Repp <jacobrepp@gmail.com>
@jrepp jrepp force-pushed the fix-receive-local-endpoint branch from cafd742 to 57bcdf2 Compare July 25, 2020 00:57
Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! lgtm

@brancz brancz merged commit a64884b into thanos-io:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants