Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: fix store gateway link in sharding.md #3682

Closed
wants to merge 1 commit into from

Conversation

rtreffer
Copy link

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fix broken link (404) from sharding.md to store.md

Store.md link: components/store.md/
Sharding.md link: thanos/sharding.md

Verification

Appending the suggested relative URL to the sharding.md results in thanos/sharding.md/../../components/store.md/ which redirects to the correct page.

Store.md link: [components/store.md/](https://thanos.io/tip/components/store.md/)
Sharding.md link: [thanos/sharding.md](https://thanos.io/tip/thanos/sharding.md/)

Appending the suggested relative URL to the sharding.md results in [thanos/sharding.md/../../components/store.md/](https://thanos.io/v0.17/thanos/sharding.md/../../components/store.md/) which redirects to the correct page.

Signed-off-by: Rene Treffer <rene.treffer@soundcloud.com>
@rtreffer
Copy link
Author

Ah, looks like this will be solved the same way as #3645

@soniasingla
Copy link
Contributor

@rtreffer you're right!

@bwplotka
Copy link
Member

Looks like it's done already. Thanks anyway for help 🤗

@bwplotka bwplotka closed this Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants