mixin: Downgrade severity of forward failures #4064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkoyun
previously approved these changes
Apr 15, 2021
We had this alert fire during a rollout, however, it is expected that during rollouts some forward requests fail. As long as ingestion as a whole is still succeeding with quorum, there's no need to alert on anything. Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
kakkoyun
approved these changes
Apr 15, 2021
someshkoli
pushed a commit
to someshkoli/thanos
that referenced
this pull request
Apr 21, 2021
We had this alert fire during a rollout, however, it is expected that during rollouts some forward requests fail. As long as ingestion as a whole is still succeeding with quorum, there's no need to alert on anything. Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com> Signed-off-by: someshkoli <kolisomesh27@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had this alert fire during a rollout, however, it is expected that during rollouts some forward requests fail. As long as ingestion as a whole is still succeeding with a quorum, there's no need to alert on anything.
Signed-off-by: Frederic Branczyk fbranczyk@gmail.com
cc @kakkoyun @squat @metalmatze