Pushdown labels values matchers API to store levels #4220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
force-pushed
the
pushdown-lb-values
branch
3 times, most recently
from
2fc851b
to
df646bb
Compare
Signed-off-by: yeya24 <yb532204897@gmail.com>
yeya24
force-pushed
the
pushdown-lb-values
branch
from
df646bb
to
7dd0182
Compare
GiedriusS
reviewed
May 27, 2021
| s := q.Select(false, nil, mset...) | ||
| sets = append(sets, s) | ||
| var callWarnings storage.Warnings | ||
| labelValuesSet := make(map[string]struct{}) |
There was a problem hiding this comment.
My only question is why are you building a map[string]struct{} here instead of adding everything directly to vals:
retrievedVals, callWarnings, err := q.LabelValues(name, matchers...)
if err != nil {
return nil, nil, &api.ApiError{Typ: api.ErrorExec, Err: err}
}
warnings = append(warnings, callWarnings...)
vals = append(vals, retrievedVals...)? 🤔 This should be more efficient.
There was a problem hiding this comment.
I think this is to filter out duplicates.
There was a problem hiding this comment.
Ahh, right! Thanks for the answer.
GiedriusS
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yeya24 yb532204897@gmail.com
Changes
Fixes #3779.
Now the labelvalue matchers push down are implemented in the TSDB store, Prometheus store, and the bucket store, thanks to @Namanl2001 and @pstibrany. Now it is ready to replace the old series approach with the new implementation.
Also, this pr adds Prometheus release v2.26.0 to our circle CI test to ensure the compatibility and correctness of the new label values matchers for newer Prometheus versions. This is mentioned in #4020 (reply in thread).
Verification