Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement stateless mode for Thanos Ruler #4250

Closed
wants to merge 18 commits into from
Closed

Implement stateless mode for Thanos Ruler #4250

wants to merge 18 commits into from

Commits on Sep 17, 2021

  1. import wal package from grafana/agent (with string interning disabled) 

    Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    64a9700 View commit details
    Browse the repository at this point in the history

  2. Set up remote-write config and test skeleton 

    Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    f651423 View commit details
    Browse the repository at this point in the history

  3. Setup fanout and related storages for stateless ruler 

    Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    0e2b82f View commit details
    Browse the repository at this point in the history

  4. Optionally run ruler in stateless mode 

    Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    02f8981 View commit details
    Browse the repository at this point in the history

  5. Set up tests and implementations for configuring remote-write for ruler 

    Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    fc8f103 View commit details
    Browse the repository at this point in the history

  6. Implement stub querier for WAL storage to fix nil pointer error 

    Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    44b6219 View commit details
    Browse the repository at this point in the history

  7. Setup e2e test for stateless ruler 

    Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    a5e3a78 View commit details
    Browse the repository at this point in the history

  8. Add copied code commentary to remotewrite packages 

    Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    f05fabd View commit details
    Browse the repository at this point in the history

  9. Use static addresses for am and querier 

    Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    7b87e52 View commit details
    Browse the repository at this point in the history

  10. Remove need for separate remote-write flag for stateless ruler 

    This removes the need to pass a separate `remote-write` flag to ruler
to enable stateless mode. Instead, we now check if a remote-write config is provided
and automatically enables stateless mode based off that.

Ruler test is also cleaned up to remove unnecessary
tests (i.e those that have been performed by other e2e suites).

Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    2729902 View commit details
    Browse the repository at this point in the history

  11. Generate docs for stateless ruler flags and fix tests 

    Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    9e033d0 View commit details
    Browse the repository at this point in the history

  12. Use promauto for prometheus primitives 

    Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    64f4c26 View commit details
    Browse the repository at this point in the history

  13. Group imports and satisfy go-lint 

    Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    0290a3d View commit details
    Browse the repository at this point in the history

  14. Always return empty series set from WAL storage 

    Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    77ee337 View commit details
    Browse the repository at this point in the history

  15. re-generate rule documentation 

    Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    933a875 View commit details
    Browse the repository at this point in the history

  16. copyright headers to satisfy golint 

    Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    41d3408 View commit details
    Browse the repository at this point in the history

  17. Rename wal storage metrics 

    Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    79b06d3 View commit details
    Browse the repository at this point in the history

  18. Use Prometheus' remote write config instead of rolling another 

    Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
    @idoqo
    idoqo committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    6b0612c View commit details
    Browse the repository at this point in the history