Azure: Support authentication using user-assigned managed identity #4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrmahdi
force-pushed
the
amrh/user-assigned-identity
branch
from
0cdb87d
to
e6e1f7a
Compare
amrmahdi
changed the title
Adds support for [user-assigned managed identity](https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/overview#managed-identity-types). When using the `user_assigned_id` the change does not require setting `msi_resource` it defaults to `https://<storage account name>.<endpoint>` unless the config explicitly sets the `msi_resource`. Tested against Azure. Signed-off-by: Amr Hanafi (MAHDI)) <amrh@microsoft.com>
amrmahdi
force-pushed
the
amrh/user-assigned-identity
branch
from
e6e1f7a
to
0b2a54a
Compare
2 tasks
wiardvanrij
previously approved these changes
Sep 3, 2021
Signed-off-by: Amr Hanafi (MAHDI)) <amrh@microsoft.com>
amrmahdi
force-pushed
the
amrh/user-assigned-identity
branch
from
c08c91a
to
29c3943
Compare
wiardvanrij
previously approved these changes
Sep 3, 2021
|
@bwplotka Hoping this can get on the 0.23 release train :) |
phillebaba
reviewed
Sep 7, 2021
Signed-off-by: Amr Hanafi (MAHDI)) <amrh@microsoft.com>
someshkoli
pushed a commit
to someshkoli/thanos
that referenced
this pull request
Nov 7, 2021
…hanos-io#4636) * Azure: Support authentication using user-assigned managed identity Adds support for [user-assigned managed identity](https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/overview#managed-identity-types). When using the `user_assigned_id` the change does not require setting `msi_resource` it defaults to `https://<storage account name>.<endpoint>` unless the config explicitly sets the `msi_resource`. Tested against Azure. Signed-off-by: Amr Hanafi (MAHDI)) <amrh@microsoft.com> * refactor service token fetch into own method Signed-off-by: Amr Hanafi (MAHDI)) <amrh@microsoft.com> * do not use deprecated method Signed-off-by: Amr Hanafi (MAHDI)) <amrh@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for user-assigned managed identity.
When using the
user_assigned_idthe change does not require settingmsi_resourceit defaults tohttps://<storage account name>.<endpoint>unless the config explicitly sets themsi_resource.Tested against Azure.
Changes
Verification