change help string of tsdb.path to "Disk space for local caches." #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, it doesn't do it on its own |
bwplotka
reviewed
Aug 10, 2018
| @@ -28,7 +28,7 @@ func registerStore(m map[string]setupFunc, app *kingpin.Application, name string | |||
|
|
|||
| grpcBindAddr, httpBindAddr, newPeerFn := regCommonServerFlags(cmd) | |||
|
|
|||
| dataDir := cmd.Flag("tsdb.path", "Data directory of TSDB."). | |||
| dataDir := cmd.Flag("tsdb.path", "Disk space for local caches."). | |||
There was a problem hiding this comment.
Very good point... I wonder if we don't want to change flag name as well...
|
Fixed by #503 Thanks anyway! |
bwplotka
added a commit
that referenced
this pull request
Jan 2, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Jan 4, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Jan 4, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Jan 4, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Jan 7, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Jan 7, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Jan 7, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Jan 7, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Jan 7, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Jan 20, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Jan 21, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Jan 21, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Jan 21, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Jan 23, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Jan 23, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com> # Conflicts: # pkg/store/bucket.go # pkg/store/bucket_e2e_test.go
bwplotka
added a commit
that referenced
this pull request
Jan 24, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com> # Conflicts: # pkg/store/bucket.go # pkg/store/bucket_e2e_test.go
bwplotka
added a commit
that referenced
this pull request
Jan 24, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com> # Conflicts: # pkg/store/bucket.go # pkg/store/bucket_e2e_test.go
bwplotka
added a commit
that referenced
this pull request
Jan 25, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Jan 25, 2019
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it touches "store" components
Changes
change help string of tsdb.path to "Disk space for local caches."
Verification