Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics for compaction and downsampling process #4801

Merged
merged 75 commits into from
Nov 6, 2021
Merged

Metrics for compaction and downsampling process #4801

merged 75 commits into from
Nov 6, 2021

Commits on Oct 16, 2021

  1. fixed template; export metadata 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    6fb9752 View commit details
    Browse the repository at this point in the history

  2. added some error handling 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    f403fcc View commit details
    Browse the repository at this point in the history

  3. remove planned blocks from original 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    02d7037 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2021

  1. moved to pkg/compact 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    ea83250 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. draft: export metrics to Prom 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    ff2e36a View commit details
    Browse the repository at this point in the history

  2. update metrics after entire plan sim; change func name 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    5961552 View commit details
    Browse the repository at this point in the history

  3. added method to delete metas from group 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    a2b2b97 View commit details
    Browse the repository at this point in the history

  4. preallocate meta slice 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    8f13acc View commit details
    Browse the repository at this point in the history

  5. changed func signature; started adding metrics to Group 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    f52e056 View commit details
    Browse the repository at this point in the history

  6. added termination condition 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    ad639c1 View commit details
    Browse the repository at this point in the history

  7. metrics struct added 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    845d497 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. draft: updating progress metric 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    cc4efe4 View commit details
    Browse the repository at this point in the history

  2. added feature flag for compact 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    322340b View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. use tsdb planner as default 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    a4642f6 View commit details
    Browse the repository at this point in the history

  2. initialised maps with size; changed metrics update map 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    3092479 View commit details
    Browse the repository at this point in the history

  3. removed extra vars; changed prom init location 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    7f91580 View commit details
    Browse the repository at this point in the history

  4. added labels and downsample resolution to metadata 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    5fd74c6 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. added termination condition; reverted planner type 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    6f0b74a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'thanos-io:main' into metrics

    @metonymic-smokey
    metonymic-smokey authored Oct 21, 2021
    Configuration menu
    Copy the full SHA
    ec3e767 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. draft: downsampling metrics overview 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    a3dfae1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'metrics' of https://github.com/metonymic-smokey/thanos … 

    …into metrics
    @metonymic-smokey
    metonymic-smokey committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    772041a View commit details
    Browse the repository at this point in the history

  3. removed extra bkt; processing individual blocks 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    ad4c704 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'thanos-io:main' into metrics

    @metonymic-smokey
    metonymic-smokey authored Oct 22, 2021
    Configuration menu
    Copy the full SHA
    3c7b8ac View commit details
    Browse the repository at this point in the history

  5. changed downsample sim logic; changed plan metric names 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    e6739d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2021

  1. re-used interface; refactoring 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    b4a662b View commit details
    Browse the repository at this point in the history

  2. draft: added Prom metrics 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    cdeb0d7 View commit details
    Browse the repository at this point in the history

  3. re-used planner; added flag; fixed interface 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    7a53935 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2021

  1. increment exporters; renamed funcs/structs 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    3b90846 View commit details
    Browse the repository at this point in the history

  2. check if downsampling is disabled 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    da04db8 View commit details
    Browse the repository at this point in the history

  3. iterate through groups instead of meta 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    8922b33 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. run both simulations repeatedly 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    81a5066 View commit details
    Browse the repository at this point in the history

  2. made naming more consistent 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    63ab795 View commit details
    Browse the repository at this point in the history

  3. added unit test for planning simulation 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    235528d View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. Merge branch 'thanos-io:main' into metrics

    @metonymic-smokey
    metonymic-smokey authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    dc301ab View commit details
    Browse the repository at this point in the history

  2. removed extra comments 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    1810ba4 View commit details
    Browse the repository at this point in the history

  3. fixed flag bug 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    a355886 View commit details
    Browse the repository at this point in the history

  4. added docs for new compact flag 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    40fa1fc View commit details
    Browse the repository at this point in the history

  5. lint fix 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    13bec69 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. added sync meta to repeat loop 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    cec1c58 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. draft: downsampling unit test 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    d8a1ab8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'thanos-io:main' into compact-metrics

    @metonymic-smokey
    metonymic-smokey authored Oct 28, 2021
    Configuration menu
    Copy the full SHA
    8b23ef3 View commit details
    Browse the repository at this point in the history

  3. new group for downsample; re-used context 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    fc71280 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'compact-metrics' of https://github.com/metonymic-smokey… 

    …/thanos into compact-metrics
    @metonymic-smokey
    metonymic-smokey committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    0460638 View commit details
    Browse the repository at this point in the history

  5. added test names and comments for downsample unit test 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    5ea12ef View commit details
    Browse the repository at this point in the history

  6. fixed copy error - changed to deep copy 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    3629986 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2021

  1. changed metric names 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    fa40551 View commit details
    Browse the repository at this point in the history

  2. changed to regular flag; recreate simulator obj every run 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    825a721 View commit details
    Browse the repository at this point in the history

  3. added explanatory comments 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    6b9b326 View commit details
    Browse the repository at this point in the history

  4. removed extra var 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    adba129 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'thanos-io:main' into compact-metrics

    @metonymic-smokey
    metonymic-smokey authored Oct 29, 2021
    Configuration menu
    Copy the full SHA
    87e9667 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2021

  1. re-register simulators 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    4d7da02 View commit details
    Browse the repository at this point in the history

  2. fixed names and comments 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    a0ea1d4 View commit details
    Browse the repository at this point in the history

  3. fix simulator obj registration 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    5c5d7b6 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. added some more test cases; table test for plan simulate 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    d788f99 View commit details
    Browse the repository at this point in the history

  2. added comments for some public methods 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    daea946 View commit details
    Browse the repository at this point in the history

  3. lint fixes 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    60bbe9e View commit details
    Browse the repository at this point in the history

  4. fixed names, logs and comments 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    9c3d11c View commit details
    Browse the repository at this point in the history

  5. refactored test 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    afd48bf View commit details
    Browse the repository at this point in the history

  6. Merge branch 'thanos-io:main' into compact-metrics

    @metonymic-smokey
    metonymic-smokey authored Nov 2, 2021
    Configuration menu
    Copy the full SHA
    54b412f View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. added test cases with two groups 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    8f1fff7 View commit details
    Browse the repository at this point in the history

  2. added test case with non consecutive blocks 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    ff3ea04 View commit details
    Browse the repository at this point in the history

  3. fixed some nits 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    fa5f03f View commit details
    Browse the repository at this point in the history

  4. fixed two_groups_test 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    3c5cbce View commit details
    Browse the repository at this point in the history

  5. updated docs 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    35c4ff7 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2021

  1. draft: refactor compact progress test 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    639b964 View commit details
    Browse the repository at this point in the history

  2. draft: refactor downsample test 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    c0caf42 View commit details
    Browse the repository at this point in the history

  3. lint fixes and code clean up 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    a58b63f View commit details
    Browse the repository at this point in the history

  4. draft: refactored compact progress test 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    8ec72e6 View commit details
    Browse the repository at this point in the history

  5. changed func signature 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    e10c845 View commit details
    Browse the repository at this point in the history

  6. draft: refactored downsample unit test to use helper func 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    3d0d375 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2021

  1. improved test cases; CircleCI fix 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    6999f7f View commit details
    Browse the repository at this point in the history

  2. use reset instead of unregister; minor nits 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    37848f1 View commit details
    Browse the repository at this point in the history

  3. improved downsample test case 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    e366232 View commit details
    Browse the repository at this point in the history

  4. E2E test fix 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    50d1be4 View commit details
    Browse the repository at this point in the history

  5. added CHANGELOG 

    Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
    @metonymic-smokey
    metonymic-smokey committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    02bb607 View commit details
    Browse the repository at this point in the history