Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append ruler labels as external labels when using stateless ruler mode #5205

Merged

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Mar 3, 2022

Signed-off-by: Ben Ye ben.ye@bytedance.com

Fixes https://cloud-native.slack.com/archives/CK5RSSC10/p1646228262242149

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

For the stateless ruler mode, we still need to add the labels as external labels written to the remote storage.

Verification

Tested it locally and updated the E2E test.

Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
@yeya24 yeya24 force-pushed the append-external-labels-stateless-ruler branch from 024aa88 to 74979a0 Compare March 3, 2022 02:06
@pull-request-size pull-request-size bot added size/XS and removed size/S labels Mar 3, 2022
Copy link
Collaborator

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@GiedriusS GiedriusS merged commit 4af52f2 into thanos-io:main Mar 3, 2022
@yeya24 yeya24 deleted the append-external-labels-stateless-ruler branch March 3, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants