Expose Endpoint Info timeout parameter #5480
Conversation
There was a problem hiding this comment.
It makes sense to introduce this parameter, but I'm a bit wary of introducing new separate flags in face of work being done in #5340. I assume one of the results will be that we will have a comprehensive endpoint configuration, instead of having individual flags. I'm just wondering if this would not mean we introduce a new flag only to deprecate it couple of releases later, when the endpoint.config will potentially supersede it. Maybe having this as a hidden flag first would make sense and then move it to the endpoint config. But maybe @bwplotka, @saswatamcode or @SrushtiSapkale can give us more qualified answer!
|
Good to know we have WIP work on that. If that's the case yeah definitely better than adding this new flag separately. |
yeya24
force-pushed
the
expose-endpoint-info
branch
from
a9ceb15
to
9bc5d41
Compare
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
yeya24
force-pushed
the
expose-endpoint-info
branch
from
9bc5d41
to
f897724
Compare
* Expose Endpoint Info timeout parameter Signed-off-by: Ben Ye <ben.ye@bytedance.com> * fix test timeout Signed-off-by: Ben Ye <ben.ye@bytedance.com> * update doc and changelog Signed-off-by: Ben Ye <ben.ye@bytedance.com> * make it a hidden flag Signed-off-by: Ben Ye <ben.ye@bytedance.com> * rebase main Signed-off-by: Ben Ye <ben.ye@bytedance.com> * fix tests Signed-off-by: Ben Ye <ben.ye@bytedance.com> Signed-off-by: Ben Ye <ben.ye@bytedance.com> Co-authored-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Signed-off-by: Ben Ye ben.ye@bytedance.com
Changes
Fixes #5450
Expose info timeout param so that users can configure it based on their use case use.
For our use case, we have Thanos Query at cloud control plane and Thanos Sidecars at edge across the world (like Asia, Africa, etc). Due to the physical location distance and network issues, 5 seconds timeout is not sufficient for all cases.
Verification