Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receive: add per request limits for remote write #5527

Merged
merged 27 commits into from
Aug 2, 2022
Merged

Receive: add per request limits for remote write #5527

merged 27 commits into from
Aug 2, 2022

Commits on Jul 20, 2022

  1. Add per request limits for remote write 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata authored Jul 20, 2022
    Configuration menu
    Copy the full SHA
    0dbf4ec View commit details
    Browse the repository at this point in the history

  2. Remove useless TODO item 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata authored Jul 20, 2022
    Configuration menu
    Copy the full SHA
    9ac2340 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. Refactor write request limits test 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    7995468 View commit details
    Browse the repository at this point in the history

  2. Add write concurrency limit to Receive 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    87cef59 View commit details
    Browse the repository at this point in the history

  3. Change write limits config option name 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    6cd031c View commit details
    Browse the repository at this point in the history

  4. Document remote write concurrenty limit 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    83ab7ca View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of https://github.com/thanos-io/thanos into dougl… 

    …ascamata/add-per-request-write-limits
    @douglascamata
    douglascamata committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    a6addd3 View commit details
    Browse the repository at this point in the history

  6. Add changelog entry 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    ab7fd37 View commit details
    Browse the repository at this point in the history

  7. Format docs 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    e836893 View commit details
    Browse the repository at this point in the history

  8. Extract request limiting logic from handler 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    3240f69 View commit details
    Browse the repository at this point in the history

  9. Add copyright header 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    1f38552 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. Add a TODO for per-tenant limits 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    77a404b View commit details
    Browse the repository at this point in the history

  2. Add default value and hide the request limit flags 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    d00ea15 View commit details
    Browse the repository at this point in the history

  3. Improve TODO comment in request limits 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    2400aac View commit details
    Browse the repository at this point in the history

  4. Update Receive docs after flags wre made hidden 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    510248a View commit details
    Browse the repository at this point in the history

  5. Add note about WIP in Receive request limits doc 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    b8943a0 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2022

  1. Fix typo in Receive docs 

    Co-authored-by: Filip Petkovski <filip.petkovsky@gmail.com>

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    7f5c41b View commit details
    Browse the repository at this point in the history

  2. Fix help text for concurrent request limit 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    7071c22 View commit details
    Browse the repository at this point in the history

  3. Use byte unit helpers for improved readability 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    2cd1014 View commit details
    Browse the repository at this point in the history

  4. Removed check for nil writeGate 

    The constructor sets the writeGate to a noopGate.

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    8561400 View commit details
    Browse the repository at this point in the history

  5. Better organize linebreaks 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    7efee5e View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Fix help text for limits hit metric 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    42d9f49 View commit details
    Browse the repository at this point in the history

  2. Apply some english feedback 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    a98bcc3 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. Improve limits & gates documentationb 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    cc83217 View commit details
    Browse the repository at this point in the history

  2. Fix import clause 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    a9b5529 View commit details
    Browse the repository at this point in the history

  3. Use a 3 node hashring for write limits test 

    This should ensure the request fanout logic cannot somehow interfere
with the request limit logic.

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    58d362b View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Fix comment 

    Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata authored Aug 1, 2022
    Configuration menu
    Copy the full SHA
    003d9aa View commit details
    Browse the repository at this point in the history