Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receive: Reload tenant limit configuration on file change #5673

Merged
merged 37 commits into from
Oct 17, 2022
Merged

Receive: Reload tenant limit configuration on file change #5673

merged 37 commits into from
Oct 17, 2022

Commits on Sep 5, 2022

  1. Create a PathOrContent reloader 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    fb52a9c View commit details
    Browse the repository at this point in the history

  2. Add docs to staticPathContent.Rewrite 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    72fbfdb View commit details
    Browse the repository at this point in the history

  3. Run goimports 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    f1828c8 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Properly cancel the context in the test 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    caaf733 View commit details
    Browse the repository at this point in the history

  2. Watch parent directory of file 

    This helps handling deletes and other situations.

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    103aab0 View commit details
    Browse the repository at this point in the history

  3. Remove useless ctx.Done() 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    a4981f6 View commit details
    Browse the repository at this point in the history

  4. Add a debounce timer to config reload 

    It helps managing situations where a create event is followed by a write or when a big file write is sent by the fsnotify backend as many write events.

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    b95bd4f View commit details
    Browse the repository at this point in the history

  5. Fix event.Op bitmask check 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    168818e View commit details
    Browse the repository at this point in the history

  6. Update lastReload 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    b2d9022 View commit details
    Browse the repository at this point in the history

  7. Fix debouncer for path content reloader 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    54d6314 View commit details
    Browse the repository at this point in the history

  8. Improve documentation of the PathContentRealoder 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    c21e084 View commit details
    Browse the repository at this point in the history

  9. Dain reload timer before resetting 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    ce4663f View commit details
    Browse the repository at this point in the history

  10. Run tests in parallel 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    e072f02 View commit details
    Browse the repository at this point in the history

  11. Simplify debouncing logic 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    066ae0a View commit details
    Browse the repository at this point in the history

  12. Add more tests to file reloader 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    bc78cc9 View commit details
    Browse the repository at this point in the history

  13. Simplify condition for triggering reload 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    2711539 View commit details
    Browse the repository at this point in the history

  14. Use absolute path to config file 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    bf4c80b View commit details
    Browse the repository at this point in the history

  15. Get rid of parallel test 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    14b87ef View commit details
    Browse the repository at this point in the history

  16. Put back 2s wait between fs operations 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    a2600a3 View commit details
    Browse the repository at this point in the history

  17. Remove useless sleep 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    9813d35 View commit details
    Browse the repository at this point in the history

  18. Stop reloadTimer when context cancelled 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    8d86e7d View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Remove unused fucntion 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    030848c View commit details
    Browse the repository at this point in the history

  2. Add missing copyright to test file 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    871b396 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:thanos-io/thanos into add-path-cont… 

    …ent-reloader
    @douglascamata
    douglascamata committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    e0bf6a2 View commit details
    Browse the repository at this point in the history

  4. Auto-reload tenant limit config on file changes 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    80a53b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Merge branch 'main' of github.com:thanos-io/thanos into add-path-cont… 

    …ent-reloader
    @douglascamata
    douglascamata committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    5522234 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Wrap error when reloading config 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    caf3bf3 View commit details
    Browse the repository at this point in the history

  2. Move limiter config reloader and update logs 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    62af70f View commit details
    Browse the repository at this point in the history

  3. Get rid of useless types and allocations 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    fba7571 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:thanos-io/thanos into add-path-cont… 

    …ent-reloader

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    b3aaa1a View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Remove errorChan from config reload starter 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    e983a70 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Retrigger CI 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    b7632d7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:thanos-io/thanos into add-path-cont… 

    …ent-reloader
    @douglascamata
    douglascamata committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    67ea81b View commit details
    Browse the repository at this point in the history

  3. Use UnRegisterer in the Limiter 

    To ensure that limit reloads will be able to re-register their metrics.

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    fd98829 View commit details
    Browse the repository at this point in the history

  4. Better guard against nil registerer in the limiter 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    ca56664 View commit details
    Browse the repository at this point in the history

  5. Remove wrong nil guard 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    315c0ea View commit details
    Browse the repository at this point in the history

  6. Retrigger CI 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    cb21419 View commit details
    Browse the repository at this point in the history