Store: add data touched by type to the dashboard #5838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
…dashboard-data-touched-fetched
…dashboard-data-touched-fetched
fpetkovski
approved these changes
Nov 25, 2022
douglascamata
added a commit
to rhobs/configuration
that referenced
this pull request
Jan 11, 2023
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> This should include the following PRs to improve the Store dashboard, with the ultimate goal in helping out deciding values for its limits: * thanos-io/thanos#5989 * thanos-io/thanos#5838
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
May 18, 2023
* Store: add data touched by type to the dashboard Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Fix captions for data fetched and touched widgets Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Douglas Camata 159076+douglascamata@users.noreply.github.com
Changes
data_typedimensions to the data touched/fetched widgets to provide deeper insights.Depends on #5819.
Verification
Tested queries in a local Grafana instance.