Support vertical sharding for label_join and label_replace functions #5889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye benye@amazon.com
Even if the query contains label manipulation functions like
label_join
andlabel_replace
, as long as there is no conflict between sharding labels and the dynamic destinations labels specified by the function, then we should be fine to shard.For example, for query
sum by (pod, dst_label) (label_join(metric, "dst_label", ",", "src_label"))
,dst_label
is the dynamic label and we sum by (pod, dst_label), we could just shard bypod
in this case.Note: if we could push down the
label_join
andlabel_replace
function to the store level while matching series, we could also support sharding dynamic labels. This could be a follow up if we think it makes sense.Changes
Support vertical sharding for label_join and label_replace functions
Verification
Updated unit tests