Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify gRPC flags for all servers #6187

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Unify gRPC flags for all servers #6187

merged 1 commit into from
Mar 8, 2023

Conversation

fpetkovski
Copy link
Contributor

Unify gRPC flags for all servers

We currently have two methods for registering gRPC server flags and they
both have slight inconsistencies.

This commit unifies gRPC flag registration and removes one of the two
redundant methods.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Unify server gRPC flags.

Verification

@fpetkovski
Unify gRPC flags for all servers
bac73a0 
We currently have two methods for registering gRPC server flags and they
both have slight inconsistencies.

This commit unifies gRPC flag registration and removes one of the two
redundant methods.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
GiedriusS
GiedriusS approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@GiedriusS GiedriusS merged commit 3ac2a5e into thanos-io:main Mar 8, 2023
@pavdmyt
Copy link
Contributor

pavdmyt commented Mar 27, 2023

The default value for --grpc-server-max-connection-age is changed from 60m to 0s, which effectively disables the connection aging and creates possibility for connections hanging infinitely. Is this a desired change? Is it possible to provide more context and reasoning about this change? Thank you.

@fpetkovski
Copy link
Contributor Author

Ah, that was not intended. The scope of the PR was to unify all gRPC flags, and I guess we had the default of 0s somewhere else. Do you want to raise a PR to fix this?

@pavdmyt
Copy link
Contributor

pavdmyt commented Mar 27, 2023

Yes, I'll open PR, thanks for clarification.

@pavdmyt pavdmyt mentioned this pull request Mar 27, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fpetkovski @pavdmyt @GiedriusS