storepb: make ServerAsClient channels unbuffered #7207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffm-make-server-as-client-channels-unbuffered
branch
from
4696c72
to
bbfb8fd
Compare
GiedriusS
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use unbuffered channels in ServerAsClient.
As far as i can tell all callsites of this function used 0 for their buffersize already. In a recent PR we found that using unbuffered channels causes ProxyStore to receive incomplete responses: https://app.circleci.com/pipelines/github/thanos-io/thanos/15685/workflows/ae306ee4-99e2-4eba-b76b-37bf906fc9b0/jobs/25975?invite=true#step-108-83819_118.
Verification