Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request ID to client grpc spans #7384

Merged
merged 1 commit into from
May 24, 2024

Conversation

fpetkovski
Copy link
Contributor

@fpetkovski fpetkovski commented May 23, 2024

This commit adds the request ID as a span tag to outgoing gRPC and incoming HTTP requests. This would allow easier correlation of traces and logs using the request ID. I still need to figure out how to attach this information to incoming gRPC tags.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

MichaHoffmann
MichaHoffmann previously approved these changes May 23, 2024
Copy link
Contributor

@MichaHoffmann MichaHoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

This commit adds the request ID as a span tag to outgoing (client)
http and gRPC requests. This would allow easier correlation
of traces and logs using the request ID.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
@fpetkovski fpetkovski enabled auto-merge May 24, 2024 10:12
@fpetkovski fpetkovski merged commit 77c8864 into thanos-io:main May 24, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants