Fixed potential buffered channel block #744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jojohappy <sarahdj0917@gmail.com>
|
Thanks for diving into this, some questions though:
|
bwplotka
added a commit
that referenced
this pull request
Jan 16, 2019
This fixes potential race condition. Bit more efficient version of #744 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Jan 16, 2019
This fixes potential race condition. Bit more efficient version of #744 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
reviewed
Jan 16, 2019
There was a problem hiding this comment.
Actually, you are totally right here! Totally missed that streamSeriesSet writes to same channel as well!
In fact we even have regression test that.. you need to be unlucky/lucky to get get this bug caught.
This is good, but I proposed more fixes to this code and more consistent flow. There were other problems as well: #745
What do you think?
Anyway thanks for highlighting the problem!
|
@bwplotka That's my pleasure. Totally agree with you. I will close this PR and review yours. |
bwplotka
added a commit
that referenced
this pull request
Jan 17, 2019
This fixes potential race condition. Bit more efficient version of #744 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
added a commit
that referenced
this pull request
Jan 17, 2019
This fixes potential race condition. Bit more efficient version of #744 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jojohappy sarahdj0917@gmail.com
Changes
I found a potential bug that would block the buffered channel and the
forloop. I also think it is the root cause of CI timeout. I tried to make a change to fix, not sure the changes are correct, but tests would be fine withoutstoretimeout.PTAL @bwplotka @domgreen Thanks!
Verification
To run
make testlocally and it will be passed.