Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docs link for supported Prometheus versions #746

Merged
merged 2 commits into from
Jan 17, 2019
Merged

fix docs link for supported Prometheus versions #746

merged 2 commits into from
Jan 17, 2019

Conversation

benclapp
Copy link
Contributor

Changes

Just a small change to fix the docs link for supported Prometheus versions after 7d30beb

bwplotka
bwplotka approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Worth to mention in Makefile envvar we reference here in some comment that it is referenced here... to remember to update it (:

@benclapp
Copy link
Contributor Author

Added the comment :)

@bwplotka
Copy link
Member

Thanks, sorry for flaky CI, it should be fixed here: #745

@bwplotka bwplotka merged commit 837f5b4 into thanos-io:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benclapp @bwplotka