-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query-frontend: Fix connection to Redis cluster with TLS. #7674
base: main
Are you sure you want to change the base?
Conversation
c96aaa8
to
cfdf1b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG - remember to add changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, could you add a changelog?
Added |
e2479b9
to
1a59739
Compare
@didukh86 you would need to sign the changelog commit as well. Could you do that, happy to merge then 🙂 |
Issue: thanos-io#7672 Signed-off-by: didukh86 <didukh86@gmail.com> Signed-off-by: didukh86 <78904472+didukh86@users.noreply.github.com> Signed-off-by: didukh86 <didukh86@gmail.com> Signed-off-by: Taras Didukh <taras.didukh@advancedmd.com>
Signed-off-by: Taras Didukh <taras.didukh@advancedmd.com>
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
…tlptracehttp (thanos-io#7666) Bumps [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp](https://github.com/open-telemetry/opentelemetry-go) from 1.27.0 to 1.29.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.27.0...v1.29.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Taras Didukh <taras.didukh@advancedmd.com>
Signed-off-by: milinddethe15 <milinddethe15@gmail.com> Signed-off-by: Taras Didukh <taras.didukh@advancedmd.com>
…io#7667) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.2 to 3.26.5. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@429e197...2c779ab) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Taras Didukh <taras.didukh@advancedmd.com>
Bumps [golang.org/x/time](https://github.com/golang/time) from 0.5.0 to 0.6.0. - [Commits](golang/time@v0.5.0...v0.6.0) --- updated-dependencies: - dependency-name: golang.org/x/time dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Taras Didukh <taras.didukh@advancedmd.com>
4888af1
to
75f0328
Compare
Signed-off-by: Taras Didukh <didukh86@gmail.com>
Signed-off-by: Taras Didukh <didukh86@gmail.com>
@saswatamcode all commits are signed and all looks fine now. Thank you for reviewing. |
Is there anything else missing for this PR to be merged? |
Issue: #7672
Signed-off-by: didukh86 didukh86@gmail.com
Changes
Added EnableTLS and InsecureSkipVerify to Redis config
Verification
After build I was able to connect to Redis cluster with TLS enabled