api: use jsoniter #7816
Merged
api: use jsoniter #7816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use jsoniter for responding. Use Prometheus codecs for that. Benchmark:
```
goos: linux
goarch: amd64
pkg: github.com/thanos-io/thanos/pkg/api
cpu: Intel(R) Core(TM) i9-10885H CPU @ 2.40GHz
│ old │ newv2 │
│ sec/op │ sec/op vs base │
Respond-16 1.497m ± 96% 1.208m ± 14% -19.32% (p=0.000 n=10)
│ old │ newv2 │
│ B/op │ B/op vs base │
Respond-16 1432.4Ki ± 227% 259.1Ki ± 1% -81.91% (p=0.000 n=10)
│ old │ newv2 │
│ allocs/op │ allocs/op vs base │
Respond-16 30.000 ± 0% 8.000 ± 0% -73.33% (p=0.000 n=10)
```
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
force-pushed
the
use_jsoniter
branch
from
43c97b6
to
612b1ad
Compare
MichaHoffmann
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use jsoniter for responding. Use Prometheus codecs for that. Benchmark:
Changes
Verification