Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLNG-10 Chnage --help option response -- FIXES #10 #11

Merged
merged 2 commits into from
Jan 12, 2018
Merged

Conversation

jwu910
Copy link
Contributor

@jwu910 jwu910 commented Jan 12, 2018

Fixes #10

@jwu910
Copy link
Contributor Author

jwu910 commented Jan 12, 2018

#10

Copy link
Contributor

@rainrivas rainrivas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove _

index.js Outdated
@@ -4,7 +4,7 @@ var program = require('commander'),
request = require('request');

program
.arguments('<slng>')
.arguments('<search_string>')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this to be snake or kebab case. we can just leave it as plain text search string

@rainrivas rainrivas changed the title SLNG-10 Chnage --help option response SLNG-10 Chnage --help option response -- FIXES #10 Jan 12, 2018
@rainrivas rainrivas merged commit f6f487b into development Jan 12, 2018
@rainrivas rainrivas deleted the SLNG-10 branch January 12, 2018 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants