Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slng 5 add color to output #18

Merged
merged 2 commits into from
Jan 14, 2018
Merged

Conversation

rainrivas
Copy link
Contributor

Fixes #5
First iteration looks like so
image

Once we finish this, I say we squash it into development

@rainrivas
Copy link
Contributor Author

@jwu910 I didn't implement everything you had in your screenshot, should I have included for those changes?

@jwu910
Copy link
Contributor

jwu910 commented Jan 14, 2018

I don't think they're necessary. But It does add a little bit of "oooh la la" to the results. Your thoughts? @rainrivas

@rainrivas
Copy link
Contributor Author

@jwu910 not sure.. your python screenshot seems to have more output than mine does. Maybe I need to make some checks into postman and figure out what's up with that

@jwu910
Copy link
Contributor

jwu910 commented Jan 14, 2018

@rainrivas yeah we took some more data from the api response. Your response should carry the same data

@rainrivas
Copy link
Contributor Author

@jwu910 sounds like new issues due to missing features

@jwu910
Copy link
Contributor

jwu910 commented Jan 14, 2018

@rainrivas do you want to add those data points in to the print results now? or just get this out to 1.0.0?

@jwu910 jwu910 merged commit 99a02c0 into development Jan 14, 2018
@jwu910 jwu910 deleted the slng-5-add-color-to-output branch January 14, 2018 09:12
@rainrivas
Copy link
Contributor Author

@jwu910 missing features will be added as part of #19 and will be in 1.0. for now we can bump to 2.0 (or can bump soon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants