Add api features to console logs for extra results information #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainrivas
requested changes
Jan 22, 2018
index.js
Outdated
| @@ -34,7 +41,11 @@ program | |||
| } | |||
| trimRes.forEach((result) => { | |||
| if (typeof (result.definition) !== undefined) { | |||
| console.log(chalk.bold.cyan('=======================\n') + result.definition); | |||
| console.log('Word: ' + chalk.magenta(result.word)); | |||
There was a problem hiding this comment.
Magenta doesn't work on my powershell @jwu910
There was a problem hiding this comment.
FYI highlighting does not help
index.js
Outdated
| @@ -24,6 +28,9 @@ program | |||
| if (err) throw new Error(err); | |||
| var trimRes; | |||
| var results = JSON.parse(body).list; | |||
|
|
|||
| console.log('='.repeat(consoleWidth())); | |||
There was a problem hiding this comment.
We removed cyan from our split, was this on purpose?
* Adding a shade of magenta to the font color and making it bold. * remove the option for additional results to display * Change magenta variable to FONT_COLOR and fix the corresponding variables with it. Removed the parenthesis around results.word
rainrivas
approved these changes
Feb 3, 2018
|
@jwu910 if you cool with the color you can merge this to dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added js api features to the console log
Edit: Fixes #19