Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team and Event Info #967

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Conversation

leongmichael
Copy link
Contributor

@leongmichael leongmichael commented Aug 13, 2024

Description

display team rookie year, event week number, remove # to team and event information

Motivation and Context

consistent with website version

How Has This Been Tested?

local

Screenshots

image image

@leongmichael leongmichael changed the title Team and Match Info Team and Event Info Aug 13, 2024
Copy link
Member

@ZachOrr ZachOrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

infoItems.append(.sponsors)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline

@ZachOrr
Copy link
Member

ZachOrr commented Aug 13, 2024

If you can remove that extra white space - I'll get this merged. Tests are busted on CI right now so - no need to worry about them passing

@ZachOrr ZachOrr merged commit 6c91ddf into the-blue-alliance:master Aug 13, 2024
@ZachOrr
Copy link
Member

ZachOrr commented Aug 13, 2024

Thank you!

@leongmichael leongmichael deleted the team-match-info branch August 13, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants