Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address some dynamic property issues with PHP 8.1 #2768

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Address some dynamic property issues with PHP 8.1 #2768

wants to merge 6 commits into from
+31 −0

Conversation

Camwyn
Copy link
Member

@Camwyn Camwyn commented Sep 19, 2023

This has no ticket (yet) - it just addresses a few reported warnings about dynamic properties in php 8.1+

@Camwyn Camwyn added the needs release Needs an associated release in Jira before merging. label Sep 19, 2023
@Camwyn Camwyn self-assigned this Sep 19, 2023
bordoni
bordoni requested changes Sep 20, 2023
View reviewed changes
Copy link
Member

@bordoni bordoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add changelog

@bordoni bordoni added the needs changelog Needs a changelog entry before merging. label Sep 20, 2023
@bordoni bordoni changed the base branch from master to release/G23.jalapeno September 20, 2023 01:33
@bordoni bordoni added code review Status: requires a code review. and removed needs release Needs an associated release in Jira before merging. labels Sep 20, 2023
@Camwyn Camwyn requested a review from bordoni September 20, 2023 13:12
bordoni
bordoni previously approved these changes Sep 22, 2023
View reviewed changes
@Camwyn Camwyn removed the needs changelog Needs a changelog entry before merging. label Oct 3, 2023
@Camwyn Camwyn changed the base branch from release/G23.jalapeno to master October 12, 2023 20:24
@Camwyn Camwyn added the needs release Needs an associated release in Jira before merging. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bordoni bordoni bordoni left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Camwyn Camwyn

Labels
code review Status: requires a code review. needs release Needs an associated release in Jira before merging.
Projects
None yet
Milestone
No milestone
2 participants
@Camwyn @bordoni