Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MonsGeek M1 #1984

Merged
merged 3 commits into from
Aug 20, 2023
Merged

Add MonsGeek M1 #1984

merged 3 commits into from
Aug 20, 2023

Conversation

adophoxia
Copy link
Contributor

Description

Adds the v3 JSON for the MonsGeek M1 now that it's been merged into upstream QMK.

QMK Pull Request

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Aug 19, 2023
View reviewed changes
v3/monsgeek/m1.json Outdated Show resolved Hide resolved
@adophoxia adophoxia requested a review from Xelus22 August 19, 2023 19:01
@Xelus22 Xelus22 merged commit 5d5c971 into the-via:master Aug 20, 2023
2 checks passed
@adophoxia adophoxia deleted the monsgeek-m1 branch August 20, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adophoxia @Xelus22