Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a quick menu on desktop #69

Merged
merged 4 commits into from
Feb 10, 2017
Merged

Conversation

Flaburgan
Copy link
Contributor

This pull request adds a menu on the left of the site to be able to navigate between the pages. There is actually two breakpoints, the menu seats next to the tiles on a big screen, switch at the top of the screen on screen < 1366 and is not displayed at all on mobile (< 642px). I will add a drawer menu on mobile on a following pull request (or in this one if it's not merged before).

@Flaburgan
Copy link
Contributor Author

Ready to be reviewed, I included the switch on mobile.

Copy link
Member

@jaywink jaywink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one missing url from the menu, then good to go! Can't wait to test :)

<li><a href="/">Home</a></li>
<li><a href="/global-stats">Global stats</a></li>
<li><a href="/diaspora">diaspora*</a></li>
<li><a href="/hubzilla">Hubzilla</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing /friendica.

@Flaburgan
Copy link
Contributor Author

Oops yes I removed both when removing redmatrix. Corrected.

@jaywink
Copy link
Member

jaywink commented Feb 9, 2017

Conflicts due to previous merge :P

@Flaburgan
Copy link
Contributor Author

Conflicts fixed.

@jaywink
Copy link
Member

jaywink commented Feb 10, 2017

Awesome, huge thanks!

@jaywink jaywink merged commit c0a2f69 into thefederationinfo:redesign Feb 10, 2017
@Flaburgan Flaburgan deleted the add-menu branch February 12, 2017 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants