-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a quick menu on desktop #69
Conversation
Ready to be reviewed, I included the switch on mobile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one missing url from the menu, then good to go! Can't wait to test :)
src/views/base.njk
Outdated
<li><a href="/">Home</a></li> | ||
<li><a href="/global-stats">Global stats</a></li> | ||
<li><a href="/diaspora">diaspora*</a></li> | ||
<li><a href="/hubzilla">Hubzilla</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing /friendica
.
Oops yes I removed both when removing redmatrix. Corrected. |
Conflicts due to previous merge :P |
Conflicts fixed. |
Awesome, huge thanks! |
This pull request adds a menu on the left of the site to be able to navigate between the pages. There is actually two breakpoints, the menu seats next to the tiles on a big screen, switch at the top of the screen on screen < 1366 and is not displayed at all on mobile (< 642px). I will add a drawer menu on mobile on a following pull request (or in this one if it's not merged before).