Fixes #30712 - pin shoulda_matcher < 4.4 #7926
Conversation
|
Issues: #30712 |
bundler.d/test.rb
Outdated
| @@ -18,7 +18,7 @@ | |||
| gem 'rubocop-rails', '~> 2.4.2' | |||
| gem 'poltergeist', '>= 1.18.0', :require => false | |||
| gem 'selenium-webdriver', :require => false | |||
| gem 'shoulda-matchers', '~> 4.0' | |||
| gem 'shoulda-matchers', '~> 4.0', '< 4.4' | |||
There was a problem hiding this comment.
The script that converts this to RPM deps creates something ugly from this. It creates < 5.0 and < 4.4.
| gem 'shoulda-matchers', '~> 4.0', '< 4.4' | |
| gem 'shoulda-matchers', '>= 4.0', '< 4.4' |
There was a problem hiding this comment.
didn't think we created rpms for test gems, but no reason to not doing it the better way for copy/paste reasons :)
There was a problem hiding this comment.
Ah, we indeed skip it for test gems so it probably wouldn't have mattered.
| @@ -18,7 +18,7 @@ | |||
| gem 'rubocop-rails', '~> 2.4.2' | |||
| gem 'poltergeist', '>= 1.18.0', :require => false | |||
| gem 'selenium-webdriver', :require => false | |||
| gem 'shoulda-matchers', '~> 4.0' | |||
| gem 'shoulda-matchers', '>= 4.0', '< 4.4' | |||
There was a problem hiding this comment.
Is it reasonable to expect they are going to fix it in the next release and just exclude the bad release?
| gem 'shoulda-matchers', '>= 4.0', '< 4.4' | |
| gem 'shoulda-matchers', '~> 4.0', '!= 4.4.0' |
There was a problem hiding this comment.
From the linked commit, it suggests it started to depend on the Zeitwerk loader. #7843 did start the effort to move Foreman to use it, but that's still a draft.
There was a problem hiding this comment.
reading the issue: thoughtbot/shoulda-matchers#1332 its unclear at this point. The change that broke it almost seems like it was intentional, but i don't know that a developer has commented on the issue.
|
@ekohl could you approve please? |
|
This probably needs chery picks. |
Only for tests to be passing though. |
|
In the issue they mentioned that 4.4.1 should fix it again. |
see thoughtbot/shoulda-matchers#1332 for details