Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: integrate Carbon Ads #876

Merged
merged 3 commits into from
Aug 11, 2023
Merged

docs: integrate Carbon Ads #876

merged 3 commits into from
Aug 11, 2023

Conversation

zoltanszogyenyi
Copy link
Member

  • I have followed the [Your First Code Contribution section of the Contributing guide]

This PR is not yet finished - throws an error for using useRouter instead of next/navigation.

@vercel
Copy link

vercel bot commented Jul 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2023 7:38pm

zoltanszogyenyi and others added 2 commits August 11, 2023 12:24
Please note Carbon Ads does not work without traditional JavaScript DOM
manipulation, and Carbon Ads are **disabled in development mode**.
@tulup-conner tulup-conner changed the title docs(carbon ads): integrate Carbon Ads based on official guide docs: integrate Carbon Ads Aug 11, 2023
@tulup-conner tulup-conner self-assigned this Aug 11, 2023
@tulup-conner tulup-conner added this to the 1.0.0 milestone Aug 11, 2023
I'm not sure why, but this test only fails in Github Actions. We should look into this ASAP, but for
now, it's breaking everyone's PRs for no good reason, so I'm just going to remove it in the
immediate term.
@tulup-conner tulup-conner merged commit 0da65fa into main Aug 11, 2023
4 checks passed
@tulup-conner tulup-conner deleted the carbon-ads branch August 11, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants