Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button.tsx): Adding back displayName #890

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

headdetect
Copy link
Contributor

Due to a recent change with <Button />, the displayName was removed from the component. This had a downstream effect of causing the docs to report that the name for this component was "No Display Name".

This change simply adds back the display name.

Screen Shot 2023-07-30 at 7 07 58 PM

@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 2:10am

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 99.85% and project coverage change: -0.02% ⚠️

Comparison is base (7461173) 99.54% compared to head (b7860d0) 99.53%.
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #890      +/-   ##
==========================================
- Coverage   99.54%   99.53%   -0.02%     
==========================================
  Files         163      167       +4     
  Lines        6621     6904     +283     
  Branches      401      417      +16     
==========================================
+ Hits         6591     6872     +281     
- Misses         30       32       +2     
Files Changed Coverage Δ
src/components/Toast/theme.ts 100.00% <ø> (ø)
src/components/Dropdown/Dropdown.tsx 99.24% <99.43%> (-0.76%) ⬇️
src/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/components/Button/Button.tsx 100.00% <100.00%> (ø)
src/components/Button/ButtonBase.tsx 100.00% <100.00%> (ø)
src/components/Button/theme.ts 100.00% <100.00%> (ø)
src/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/components/Carousel/Carousel.tsx 99.02% <100.00%> (+0.06%) ⬆️
src/components/DarkThemeToggle/DarkThemeToggle.tsx 100.00% <100.00%> (ø)
src/components/Dropdown/DropdownItem.tsx 100.00% <100.00%> (ø)
... and 18 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rluders rluders linked an issue Jul 31, 2023 that may be closed by this pull request
2 tasks
@rluders rluders merged commit 8e24575 into themesberg:main Jul 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<No Display Name type="submit"> Submit </No Display Name> line is giving error
3 participants