Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 8 Compatibility #286

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Laravel 8 Compatibility #286

merged 3 commits into from
Sep 22, 2020

Conversation

pkracer
Copy link
Contributor

@pkracer pkracer commented Sep 12, 2020

This PR updates the laravel/framework dependency to work with either Laravel 7 or 8.

The default route namespace has been removed from the WinkServiceProvider. All controller declarations have been updated to use the standard PHP callable syntax.

@topclaudy
Copy link

Please merge this.

@vinzce
Copy link

vinzce commented Sep 18, 2020

I need this

@pkracer
Copy link
Contributor Author

pkracer commented Sep 19, 2020

While waiting for this to be merged, you can fork this repository, update your fork with the changes from this PR, and use it in your project instead.

For example, I forked this repository, cloned my fork down to a directory named wink-fork, updated my fork with the changes from this PR, and then updated my project's composer.json to use my fork instead.

composer.json

    "repositories": [
        {
            "type": "path",
            "url": "../wink-fork",
            "options": {
                "symlink": false
            }
        }
    ]

@topclaudy
Copy link

@pkracer If you don't want to fork, use https://github.com/cweagans/composer-patches

@relaypilot
Copy link

relaypilot commented Sep 19, 2020

@pkracer Thank you for the tip! It works perfectly on local.

However when I deploy on my prod server, the composer install command fails:
When deploying, the following command is ran by my server:

git pull origin master
composer install --no-interaction --prefer-dist --optimize-autoloader

And the error output:

Source path "../wink-fork" is not found for package themsaid/wink

@pkracer
Copy link
Contributor Author

pkracer commented Sep 19, 2020

I'm guessing that it's looking for a directory (wink-fork) that doesn't exist. You just need to clone the fork down on your prod server as well, the same as you did for local. Make sure you commit those PR changes to your fork first!

@themsaid themsaid merged commit cdbb27a into themsaid:1.x Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants