Merge pull request #1013 from xavierlacot/fix/css-level-3-selectors

Allow CSS level 3 selectors for classes and ids in the attributes extension
thephpleague · Jul 22, 2024 · fd3c4e6 · fd3c4e6
2 parents fd45b92 + d24a759
commit fd3c4e6
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 1 deletion.
diff --git a/src/Extension/Attributes/Util/AttributesHelper.php b/src/Extension/Attributes/Util/AttributesHelper.php
@@ -23,7 +23,7 @@
  */
 final class AttributesHelper
 {
-    private const SINGLE_ATTRIBUTE = '\s*([.#][_a-z0-9-]+|' . RegexHelper::PARTIAL_ATTRIBUTENAME . RegexHelper::PARTIAL_ATTRIBUTEVALUESPEC . ')\s*';
+    private const SINGLE_ATTRIBUTE = '\s*([.]-?[_a-z]\S*|[#]\S+|' . RegexHelper::PARTIAL_ATTRIBUTENAME . RegexHelper::PARTIAL_ATTRIBUTEVALUESPEC . ')\s*';
     private const ATTRIBUTE_LIST   = '/^{:?(' . self::SINGLE_ATTRIBUTE . ')+}/i';
 
     /**

diff --git a/tests/functional/Extension/Attributes/data/class_names.html b/tests/functional/Extension/Attributes/data/class_names.html
@@ -0,0 +1,6 @@
+<p class="some-class(value)">Some text</p>
+<p class="some-class(value)">Some text</p>
+<p class="-hello">Some text</p>
+<p class="smile-😎 some-class">Some text</p>
+<p id="smile-😎">Some text</p>
+<p id="smile-😎">Some text</p>
diff --git a/tests/functional/Extension/Attributes/data/class_names.md b/tests/functional/Extension/Attributes/data/class_names.md
@@ -0,0 +1,17 @@
+{class="some-class(value)"}
+Some text
+
+{.some-class(value)}
+Some text
+
+{.-hello}
+Some text
+
+{.smile-😎 .some-class}
+Some text
+
+{id="smile-😎"}
+Some text
+
+{#smile-😎}
+Some text