Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with node locations #187

Closed
fesor opened this issue Sep 26, 2015 · 1 comment
Closed

Issue with node locations #187

fesor opened this issue Sep 26, 2015 · 1 comment
Labels
bug Something isn't working right

Comments

@fesor
Copy link
Contributor

fesor commented Sep 26, 2015

Example:

line 1
line 2
line 3

Expected that paragraph will has endLine equal 3, but it equals 2 instead. I think that this happens because document was trimmed and last line was removed.
colinodell added a commit that referenced this issue Sep 27, 2015
@colinodell
Fix incorrect endLine positions (#187)
36cdd2e 
This requires manually passing in the appropriate endLine to `AbstractBlock::finalize()`
as a new parameter.
@colinodell
Copy link
Member

This has been fixed and will be included in the next release. Thanks for reporting it!

@colinodell colinodell added the bug Something isn't working right label Sep 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fesor @colinodell