Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question About convertToHtml #26

Closed
GrahamCampbell opened this issue Dec 23, 2014 · 2 comments
Closed

Question About convertToHtml #26

GrahamCampbell opened this issue Dec 23, 2014 · 2 comments

Comments

@GrahamCampbell
Copy link
Member

Why are creating new classes over and over in the convertToHtml method? I don't understand why you don't do that bit in the constructor?
@GrahamCampbell GrahamCampbell mentioned this issue Dec 23, 2014
Merged
@colinodell
Copy link
Member

Good catch! There's one small bug with your change, but once fixed I'll gladly accept the PR :)

@GrahamCampbell
Copy link
Member Author

Great. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colinodell @GrahamCampbell