Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the commonmark converter class #27

Merged
merged 3 commits into from
Dec 23, 2014
Merged

Refactor the commonmark converter class #27

merged 3 commits into from
Dec 23, 2014

Conversation

GrahamCampbell
Copy link
Member

Addresses #26.

colinodell
colinodell reviewed Dec 23, 2014
View reviewed changes
src/CommonMarkConverter.php
{
$environment = Environment::createCommonMarkEnvironment();
$this->docParser = new DocParser($environment);
$this->renderer = new HtmlRenderer($environment);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to reference $htmlRenderer instead.

https://scrutinizer-ci.com/g/thephpleague/commonmark/inspections/d9a558a8-aac1-47f3-a6bd-dac1dec28e71/issues/files/src/CommonMarkConverter.php?status=new&orderField=path&order=asc

@GrahamCampbell
Copy link
Member Author

Fixed.

@GrahamCampbell
Removed trailing whitespace
527dfb3 
Damn the github online editor!
colinodell added a commit that referenced this pull request Dec 23, 2014
@colinodell
Merge pull request #27 from GrahamCampbell/patch-2
88a6ef8 
Refactor the commonmark converter class
@colinodell colinodell merged commit 88a6ef8 into thephpleague:master Dec 23, 2014
@colinodell
Copy link
Member

Thanks for the contribution!

@GrahamCampbell GrahamCampbell deleted the patch-2 branch December 23, 2014 19:57
@GrahamCampbell
Copy link
Member Author

No problem. This looks like an awesome project. :)

@GrahamCampbell
Copy link
Member Author

I'm going to switch to it in the next major release of https://github.com/GrahamCampbell/Laravel-Markdown.

@GrahamCampbell
Copy link
Member Author

FYI: GrahamCampbell/Laravel-Markdown@2e66322.

@colinodell
Copy link
Member

That's awesome!

BTW I'm hoping to release version 0.5 in the next day or two, which includes the major refactoring present in master. It's a bit slower than 0.4 due to the extra abstractions, but it's still within reason (~80ms in my benchmark) and infinitely more customizable.

@GrahamCampbell
Copy link
Member Author

Great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrahamCampbell @colinodell