Remove mbstring as a dependency #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
php 5.3 and hhvm aren't happy. |
|
I get emails about that. :) |
Before 82421eb, the mb_decode_numericentity function wouldn't convert code points beyond plane 2 (per the flags). This change essentially adds the same behavior.
|
Thanks for getting this started! I've resolved the current failures and am working on |
| @@ -36,7 +36,8 @@ public static function detabLine($string) | |||
|
|
|||
| foreach ($parts as $part) { | |||
| // Calculate number of spaces; insert them followed by the non-tab contents | |||
| $amount = 4 - mb_strlen($line, 'UTF-8') % 4; | |||
| $lineLength = strlen(utf8_decode($line)); | |||
There was a problem hiding this comment.
are you sure this works with non ascii characters? You should include some tests for this.
There was a problem hiding this comment.
Yep it does. utf8_decode will turn the multi-byte characters into a single byte representation. It's okay if the conversion fails (and we get ? characters) since we just need a count here.
Per the spec, reference link matching is done by normalizing the label with a Unicode case fold, which mb_strtoupper provides. But since not all systems have the relevant extension installed, we need to manually implement this logic by converting characters according to this table: http://www.unicode.org/Public/UNIDATA/CaseFolding.txt
colinodell
added a commit
that referenced
this pull request
Dec 27, 2014
Remove mbstring as a dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Half done with #38, but 2 of the 3 uses are removed.
Found some weird hack for string length that involves regex. I'll take it.
Not sure what to do about
mb_strtoupper()though.https://github.com/thephpleague/commonmark/search?utf8=%E2%9C%93&q=mb_strtoupper&type=Code