[WIP]: move trim from parser to renderer #924
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a PHPCS bug that I don't understand what is wrong with it: "Incorrect annotations group."
Locally there are still 4 PHPUnit tests which fail. But I am not sure if there is not a fundamental error in thinking there.
Because in XML there is the flag "xml:space="preserve"". It could even be that the test needs to be rethought.
This pull-request is just to give you the opportunity to think about my suggestion (#923) and see how I implemented it.