Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a typo in the section documentation #225

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Fixing a typo in the section documentation #225

merged 1 commit into from
Jul 30, 2018

Conversation

filhocodes
Copy link

I know you guys are working on V4, and this is meaningless, but just to get it right 😅.

@ragboyjr ragboyjr merged commit 1b29776 into thephpleague:v3 Jul 30, 2018
@ragboyjr
Copy link
Contributor

Not meaningless :), thanks for the PR!

@filhocodes
Copy link
Author

❤️

@ragboyjr just gonna abuse this moment to ask a question, do you guys add <?php /** @var Type $var */ ?> add the start of the templates so IDEs like PHPStorm can give you a better support for inspections and autocomplete and so on, or you do in another way, or neither?

@ragboyjr
Copy link
Contributor

@marcossffilho #222

yes, and that's something I want to work better for v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@filhocodes @ragboyjr