Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move common Auth3000 functions to own file #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: move common Auth3000 functions to own file #46

wants to merge 1 commit into from

Conversation

coolaj86
Copy link
Contributor

@coolaj86 coolaj86 commented Dec 8, 2021

for reuse

coolaj86
coolaj86 commented Jan 2, 2022
View reviewed changes
public/js/auth3000.js
.join("&");
};

Auth3000.parseQuerystring = function (querystring) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

new URLSearchParams(querystring)

coolaj86
coolaj86 commented Jan 2, 2022
View reviewed changes
public/js/auth3000.js
) {
// a secure-enough random state value
// (all modern browsers use crypto random Math.random, not that it much matters for a client-side state cache)
var rnd = Math.random().toString();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

var rnd = window.crypto.randomUUID();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@coolaj86