Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

west.yml: update Zephyr to f9f44b6dcdd (Mar 07) #8913

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Mar 6, 2024

Switch back to main Zephyr repository and commit 0d5a670f4f073.

This includes multiple changes to fix compilation with Zephyr commit "hwmv2: Introduce Hardware model version 2 and convert devices".

@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 6, 2024

@iuliana-prodan Is zephyrproject-rtos#40 mandatory update for IMX, or can we do these incrementally? For Intel targets, some targets work with transitionary definitions, but at least INtel MTL targets were broken with the update as some of the SOC series Kconfig options were renamed in the process and SOF was using these in multiple places.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 6, 2024

I guess we need to cherry-pick IMX changes when updating as I can see some IMX builds failing https://github.com/thesofproject/sof/actions/runs/8171751130/job/22340660139?pr=8913

In local test, I still managed to hit zephyrproject-rtos/zephyr#69807 so this can be also a problem for merge (but lets' see whether CI agrees with my local tests or not).

@iuliana-prodan
Copy link
Contributor

@iuliana-prodan Is zephyrproject-rtos#40 mandatory update for IMX, or can we do these incrementally? For Intel targets, some targets work with transitionary definitions, but at least INtel MTL targets were broken with the update as some of the SOC series Kconfig options were renamed in the process and SOF was using these in multiple places.

Yes, is mandatory for zephyr/main (which has hwmv2).
Otherwise SOF for imx won't compile.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 6, 2024

Let me submit again, I didn't realize https://github.com/zephyrproject-rtos/sof/commits/zephyr/ has the patches. Let me squash them up and merge.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 6, 2024

The "sof-ci/jenkins/pr-buld" fail requires actions on SOF CI jenkins jobs, the changed path with HWMv2 trigger errors in the tools build.

There's also additional error in the imx build -> https://github.com/thesofproject/sof/actions/runs/8175491141/job/22352725234?pr=8913 ? Something with imx.toml file. Can you check @iuliana-prodan ?

@iuliana-prodan
Copy link
Contributor

The "sof-ci/jenkins/pr-buld" fail requires actions on SOF CI jenkins jobs, the changed path with HWMv2 trigger errors in the tools build.

There's also additional error in the imx build -> https://github.com/thesofproject/sof/actions/runs/8175491141/job/22352725234?pr=8913 ? Something with imx.toml file. Can you check @iuliana-prodan ?

I'm sorry, I forgot about this.. actually I thought is merged: zephyrproject-rtos/zephyr#69776

@kv2019i if you can merge it, it will be great!

marc-hb added a commit to marc-hb/sof that referenced this pull request Mar 7, 2024
Installing most of the tools/ directory does not technically require
building any platform, so add that possibility.

This is useful because the Jenkins-based CI builds the (userspace) tools
separately. So far it has been picking hardcoded source paths but of
course the HWMv2 transition just broke that:
thesofproject#8913

While it's too late this time (we want to keep CI able to test stable
branches for some time), this commit prepares a future where all CIs can
stop hardcoding Zephyr source paths and pick the output of the
xtensa-build-zephyr.py installer and indirection layer instead.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
Copy link
Collaborator

marc-hb commented Mar 7, 2024

In https://sof-ci.01.org/sof-pr-viewer/#/build/PR8913/build13681617, the same test failed the same way on both MTL and LNL (other tests passed). That would be too much of a coincidence so it is most likely caused by this PR

TestKDTopologies.test_003_01_kd_topology_host_gw[2ch-24in32bit-]


10:47:28,560 INFO  - E TimeoutError: FW status on IPC timeout after 5.0 seconds:
10:47:28,560 INFO  - E FW status: 0x00000005
10:47:28,560 INFO  - E Last error code: 0x00000000 (ADSP_SUCCESS)

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 7, 2024

SOFCI TEST

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 7, 2024

The "sof-ci/jenkins/pr-buld" fail requires actions on SOF CI jenkins jobs, the changed path with HWMv2 trigger errors in the tools build.

Done, https://sof-ci.01.org/sofpr/PR8913/build3193/build was successful. Thanks @keqiaozhang for testing my quick fix.

Now the tests are running and you can move to the next step: looking at DSP panics...

@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 7, 2024

V3 attempt:

I'll mark this as DNM for now, but let's see if CI all passes (they should).

@kv2019i kv2019i added the DNM Do Not Merge tag label Mar 7, 2024
@kv2019i kv2019i changed the title west.yml: update Zephyr to 0d5a670f4f073 [DNM] west.yml: update Zephyr to 0d5a670f4f073 Mar 7, 2024
@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 7, 2024

@iuliana-prodan can you check, there seems to be still something left, I see two failures with IMX targets. Hopefully I picked the right patches.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 7, 2024

@marc-hb It seems the HWMv2 (or some change that came here as well) has broken the Linux-windows build check
https://github.com/thesofproject/sof/actions/runs/8184833177/job/22380383895?pr=8913

 + diff -qr 'linux-build -d mtl' 'windows-build -d mtl'
Files linux-build -d mtl/build-sof-staging/sof-info/mtl/generated_configs.c and windows-build -d mtl/build-sof-staging/sof-info/mtl/generated_configs.c differ

@iuliana-prodan
Copy link
Contributor

@iuliana-prodan can you check, there seems to be still something left, I see two failures with IMX targets. Hopefully I picked the right patches.

From the error /zep_workspace/sof/tools/rimage/config/imx.toml: error: unable to open file for reading. No such file or directory (errno = 2) seems PR is missing.
I see now that PR was merged.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 7, 2024

@iuliana-prodan wrote:

From the error /zep_workspace/sof/tools/rimage/config/imx.toml: error: unable to open file for reading. No such file or directory (errno = 2) seems PR is missing. I see now that PR was merged.

You are right, thanks for checking! It seems our github checks do not work correctly when the remote is overridden. I can see the extra commits are fetched, but the actual test is still run with Zephyr main (and it fails):
https://github.com/thesofproject/sof/actions/runs/8184833177/job/22380013144?pr=8913
FYI @marc-hb

Oh well, your patches is merged to Zephyr now, so I can update the PR using the merged commit.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 7, 2024

Looking better but failure seen in https://sof-ci.01.org/sofpr/PR8913/build3197/devicetest/index.html
This seems to be a SET_DX fail #8642 ... a known issue with fixes in pipeline on Zephyr side.

@kv2019i kv2019i changed the title [DNM] west.yml: update Zephyr to 0d5a670f4f073 west.yml: update Zephyr to 0d5a670f4f073 Mar 7, 2024
@kv2019i kv2019i removed the DNM Do Not Merge tag label Mar 7, 2024
@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 7, 2024

V4:

  • newer Zephyr to include fix for imx.toml fail
  • drop the Zephyr branch, so we can remove the DNM tag

@kv2019i kv2019i changed the title west.yml: update Zephyr to 0d5a670f4f073 west.yml: update Zephyr to f9f44b6dcdd (Mar 07) Mar 7, 2024
@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 7, 2024

ARM64 build is failing, seems PLATFORM definition is missing:
https://github.com/thesofproject/sof/actions/runs/8187912559/job/22389417387?pr=8913

The expected fails for Intel targets in https://sof-ci.01.org/sofpr/PR8913/build3203/devicetest/index.html

The fail in Internal Intel CI System/merge/build is problematic as that's a required CI check, will investigate.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 7, 2024

FYI @serhiy-katsyuba-intel this is a bit strange. The KD test is failing to (id 13685882):

[    0.198605] <inf> pipe: pipeline_trigger: pipe:2 0x0 pipe trigger cmd 7
[    0.198611] <inf> ll_schedule: zephyr_ll_task_schedule_common: task add 0xa01ceb80 0x20210U priority 0 flags 0x0
[    0.199401] <inf> host_comp: host_get_copy_bytes_normal: comp:2 0x10004 no bytes to copy, available samples: 0, free_samples: 384
[    0.200385] <inf> host_comp: host_get_copy_bytes_normal: comp:2 0x10004 no bytes to copy, available samples: 0, free_samples: 384
[    0.201386] <inf> host_comp: host_get_copy_bytes_normal: comp:2 0x10004 no bytes to copy, available samples: 0, free_samples: 384

This is with today's Zephyr main. This looks a lot like a case of #8770 but why it's triggering herein the quickbuild test I have no idea.

@iuliana-prodan
Copy link
Contributor

ARM64 build is failing, seems PLATFORM definition is missing: https://github.com/thesofproject/sof/actions/runs/8187912559/job/22389417387?pr=8913

This should fix the failure for arm64 with Zephyr/main: #8918

Switch back to main Zephyr repository and commit f9f44b6dcdd.

This includes following squashed SOF commits that are
needed to adapt to HWMv2 changes in Zephyr:

zephyr: app: scripts: intel_adsp: change board names to HWMv2
zephyr: sof: update board name for HWMv2
zephyr: intel_adsp: Change ACE SoC name to HWMv2
app: boards: imx93: updates for zephyr hwmv2

Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 7, 2024

V5:

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 7, 2024

You are right, thanks for checking! It seems our github checks do not work correctly when the remote is overridden. I can see the extra commits are fetched, but the actual test is still run with Zephyr main (and it fails):
https://github.com/thesofproject/sof/actions/runs/8184833177/job/22380013144?pr=8913
FYI @marc-hb

This was run 1h and 6 16 minutes before @iuliana-prodan's Zephyr PR was merged so it looks good to me.

Thu, 07 Mar 2024 08:08:30 GMT === updating zephyr (zephyr):
Thu, 07 Mar 2024 08:08:30 GMT --- zephyr: fetching, need revision main
Thu, 07 Mar 2024 08:08:30 GMT From https://github.com/zephyrproject-rtos/zephyr
Thu, 07 Mar 2024 08:08:30 GMT  * branch                main       -> FETCH_HEAD
Thu, 07 Mar 2024 08:08:31 GMT  Warning: you are leaving 2 commits behind, not connected to
Thu, 07 Mar 2024 08:08:31 GMT any of your branches:
Thu, 07 Mar 2024 08:08:31 GMT
Thu, 07 Mar 2024 08:08:31 GMT  457476a12 boards: nxp: set correct rimage target for ADSP
Thu, 07 Mar 2024 08:08:31 GMT   5d6d2c19d Revert "pm: Remove CURRENT_CPU macro"

export TZ=UTC
git show --format=fuller --date=rfc-local 7a0398e65711

commit 7a0398e65711a980e4e3eec328754d4dd0a34adf
Author:     Iuliana Prodan <iuliana.prodan@nxp.com>
AuthorDate: Mon, 4 Mar 2024 23:23:14 +0000
Commit:     Alberto Escolar <alberto.escolar.piedras@nordicsemi.no>
CommitDate: Thu, 7 Mar 2024 08:24:22 +0000

    boards: nxp: set correct rimage target for ADSP

EDIT: "zmain" in later run https://github.com/thesofproject/sof/actions/runs/8193558383?pr=8913 is now fine

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 7, 2024

Files linux-build -d mtl/build-sof-staging/sof-info/mtl/generated_configs.c
and windows-build -d mtl/build-sof-staging/sof-info/mtl/generated_configs.c differ

generated_configs.c used to be in a deterministic order. It's not any more but the content is still the same. Someone probably started using a non-deterministic Python set, it's typical. I'll bisect and fix as usual.

As long as ONLY the generated_configs.c is different, then do not let that block this PR. The binaries are still identical which is what really matters.

Now racing to quickly fix this while other, much harder failures hold this for longer...

@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 7, 2024

@wszypelt Can you check? The quickbuild run (13687837) failed again what seems to like result copying issue, and not the actual test case.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 7, 2024

https://sof-ci.01.org/sofpr/PR8913/build3216/devicetest/index.html looks pretty bad. Submitted zephyrproject-rtos/zephyr#69937 as it likes solving this (without revert) will take more time.

@wszypelt
Copy link

wszypelt commented Mar 8, 2024

@kv2019i sure, there was a problem with the LNL testing machine, I've already added this PR to the queue. I think there will be new results within an hour

@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 8, 2024

https://sof-ci.01.org/sofpr/PR8913/build3216/devicetest/index.html is not great, but we have to progress with the HWMv2 changes and the problem on MTL has to be fixed at the source (i.e. Zephyr upstream), so I'll proceed and merge this.

@kv2019i kv2019i merged commit 22b3518 into thesofproject:main Mar 8, 2024
41 of 44 checks passed
@marc-hb
Copy link
Collaborator

marc-hb commented Mar 8, 2024

marc-hb added a commit to marc-hb/sof that referenced this pull request Mar 8, 2024
Installing most of the tools/ directory does not technically require
building any platform, so add that possibility.

This is useful because the Jenkins-based CI builds the (userspace) tools
separately. So far it has been picking hardcoded source paths but of
course the HWMv2 transition just broke that:
thesofproject#8913

While it's too late this time (we want to keep CI able to test stable
branches for some time), this commit prepares a future where all CIs can
stop hardcoding Zephyr source paths and pick the output of the
xtensa-build-zephyr.py installer and indirection layer instead.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb added a commit to marc-hb/sof that referenced this pull request Mar 16, 2024
Installing most of the tools/ directory does not technically require
building any platform, so add that possibility.

This is useful because the Jenkins-based CI builds the (userspace) tools
separately. So far it has been picking hardcoded source paths but of
course the HWMv2 transition just broke that:
thesofproject#8913

While it's too late this time (we want to keep CI able to test stable
branches for some time), this commit prepares a future where all CIs can
stop hardcoding Zephyr source paths and pick the output of the
xtensa-build-zephyr.py installer and indirection layer instead.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
kv2019i pushed a commit that referenced this pull request Apr 22, 2024
Installing most of the tools/ directory does not technically require
building any platform, so add that possibility.

This is useful because the Jenkins-based CI builds the (userspace) tools
separately. So far it has been picking hardcoded source paths but of
course the HWMv2 transition just broke that:
#8913

While it's too late this time (we want to keep CI able to test stable
branches for some time), this commit prepares a future where all CIs can
stop hardcoding Zephyr source paths and pick the output of the
xtensa-build-zephyr.py installer and indirection layer instead.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
eddy1021 pushed a commit to eddy1021/sof that referenced this pull request Jul 15, 2024
Installing most of the tools/ directory does not technically require
building any platform, so add that possibility.

This is useful because the Jenkins-based CI builds the (userspace) tools
separately. So far it has been picking hardcoded source paths but of
course the HWMv2 transition just broke that:
thesofproject#8913

While it's too late this time (we want to keep CI able to test stable
branches for some time), this commit prepares a future where all CIs can
stop hardcoding Zephyr source paths and pick the output of the
xtensa-build-zephyr.py installer and indirection layer instead.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants