platform: remove platform/drivers/idc.h for Intel platforms #9049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kv2019i
requested review from
lyakh,
iuliana-prodan,
dbaluta,
abonislawski,
lgirdwood,
plbossart,
mmaka1 and
lbetlej
as code owners
|
@thesofproject/nxp This should be good for all IMX platforms as we link zephyr_idc.c for all Zephyr SOF platforms. So I think the dummy definition of idc_send_msg() you have in many IMX idc.h platform headers, could be removed as well. I was not sure which platforms are Zephyr-only already. so didn't add this change to this PR yet. |
lgirdwood
approved these changes
Apr 15, 2024
LaurentiuM1234
approved these changes
Apr 15, 2024
abonislawski
approved these changes
Apr 15, 2024
tmleman
approved these changes
Apr 15, 2024
kv2019i
force-pushed
the
202404-plat-idc-removal
branch
from
74424e0
to
2f5045e
Compare
|
V2:
|
Ensure idc_send_msg() is implemented for all platforms linking zephyr_idc. For non-multicore, idc_send_msg() will return -ENOTSUP error. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202404-plat-idc-removal
branch
from
2f5045e
to
816d2fc
Compare
|
V3:
|
For Zephyr builds, only definition needed from platform/drivers/idc.h was prototype for idc_send_msg(). There's no need to keep the platform layer just for this, so add the definition to rtos/idc.h for Zephyr builds, and remove the platform/drivers/idc.h for all Intel platforms. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202404-plat-idc-removal
branch
from
816d2fc
to
bd9fc83
Compare
|
V4:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Zephyr builds, only definition needed from platform/drivers/idc.h was prototype for idc_send_msg(). There's no need to keep the platform layer just for this, so add the definition to rtos/idc.h for Zephyr builds, and remove the platform/drivers/idc.h for all Intel platforms.