volume: fix fadeout curve shape #9074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fadeout curve had inaccurate shape due to incorrect computation of ramp function. Suggested by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
tobonex
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
singalsu
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Thanks for the fix! As explanation I had no idea the Windows fade equation needs slightly different form to keep the shape as concave for both volume increase and volume decrease (slow gain change with low volumes). Earlier the the fade-out was convex shape (slow gain change in beginning of ramp).
kv2019i
approved these changes
Apr 23, 2024
lgirdwood
approved these changes
Apr 23, 2024
|
Ready to go, but we need a clean run of the required CI checks. @tobonex can you check the quickbuild issue? |
tmleman
approved these changes
Apr 24, 2024
abonislawski
approved these changes
Apr 25, 2024
|
@wszypelt good to merge ? |
|
@lrudyX good to merge ? |
There are some CI problems. Lets wait for rerun. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fadeout curve had inaccurate shape due to incorrect computation of ramp function for fadeout case. This patch fixes the problem.